remove wrong conversions from or to base64
authorMatthieu Gallien <matthieu.gallien@nextcloud.com>
Wed, 5 Feb 2025 12:01:16 +0000 (13:01 +0100)
committerMatthieu Gallien <matthieu.gallien@nextcloud.com>
Fri, 7 Feb 2025 08:12:29 +0000 (09:12 +0100)
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
src/libsync/foldermetadata.cpp

index 36ecd91cb9a95b568c949d2bf433001a7da1f587..bef57f92eb75983928ec14cce7bf684fb3f93503 100644 (file)
@@ -161,7 +161,7 @@ void FolderMetadata::setupExistingMetadata(const QByteArray &metadata)
         /* TODO: does it make sense to store each certificatePem that has been successfuly verified? Is this secure?
         /  Can the attacker use outdated certificate as an attack vector?*/
         folderUser.certificatePem = folderUserObject.value(usersCertificateKey).toString().toUtf8();
-        folderUser.encryptedMetadataKey = QByteArray::fromBase64(folderUserObject.value(usersEncryptedMetadataKey).toString().toUtf8());
+        folderUser.encryptedMetadataKey = folderUserObject.value(usersEncryptedMetadataKey).toString().toUtf8();
         _folderUsers[userId] = folderUser;
     }
 
@@ -668,7 +668,7 @@ QByteArray FolderMetadata::encryptedMetadata()
 
             const QJsonObject folderUserJson{{usersUserIdKey, folderUser.userId},
                                              {usersCertificateKey, QJsonValue::fromVariant(folderUser.certificatePem)},
-                                             {usersEncryptedMetadataKey, QJsonValue::fromVariant(folderUser.encryptedMetadataKey.toBase64())}};
+                                             {usersEncryptedMetadataKey, QJsonValue::fromVariant(folderUser.encryptedMetadataKey)}};
             folderUsers.push_back(folderUserJson);
         }
     }